Workflow Artifact Info Hover by bircni · Pull Request #37100 · go-gitea/gitea

bircni · 2026-04-03T21:40:45Z

Add expiry metadata to action artifacts in the run view and show it on hover.

silverwind · 2026-04-03T22:48:35Z

Can you add the hover over the actual link, not the parent div? That way the triangle of the tooltip should be aligned correctly and not point to nothing.

options/locale/locale_en-US.json

bircni · 2026-04-04T09:48:26Z

Can you add the hover over the actual link, not the parent div? That way the triangle of the tooltip should be aligned correctly and not point to nothing.

I tried, it is currently at the link but it somehow doesnt work - Could you help me? @silverwind

silverwind · 2026-04-04T15:49:38Z

I think you can just produce the <relative-time> element in JS. tippy is capable of HTML tooltip content via an option, called html=true iirc.

- Use relative-time element for date formatting in tooltip - Extract formatFileSize to shared utility web_src/js/utils/size.ts - Remove custom Intl.DateTimeFormat, ArtifactTooltipLocale type, Size label - Use createTippy with DOM element content via ref callback - Use muted link style for active artifacts, faded style for expired - Add semibold to sidebar section headings - Skip tooltip on expired artifacts - Disable tooltip arrow, use top-end placement Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-09T20:07:44Z

Did a number of tweaks and fixes, now using relative-time:

Move vertical padding from li to first-child so the link covers the full row height. Reduce tooltip offset to 2px. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-09T20:15:48Z

Also one notable change: Expired artifacts don't show a tooltip. I noticed the DB apparently stores the size of expired artifacts but imho it's a rarely useful and confusing info to display size of a expired artifact.

Also backport as a no-risk enhancement.

- Move formatBytes (renamed from formatFileSize) into web_src/js/utils.ts - Remove web_src/js/utils/size.ts - Move artifact li padding to first-child for full-height click area - Reduce tooltip offset to 2px Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Copilot

Pull request overview

Adds artifact expiry metadata (and size) to the Actions run view and displays it as a hover tooltip in the sidebar artifact list, backed by new backend fields and frontend formatting helpers.

Changes:

Extend backend artifact metadata to include expired_unix and expose it as expiresUnix in the actions run view response.
Add frontend tooltip generation for artifacts (expiry via <relative-time> + formatted size).
Introduce a shared formatBytes() utility and corresponding unit tests; add new locale key for “Expires at %s”.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
web_src/js/utils.ts	Adds `formatBytes()` helper for human-readable artifact sizes.
web_src/js/utils.test.ts	Adds unit tests for `formatBytes()`.
web_src/js/modules/gitea-actions.ts	Extends `ActionsArtifact` type with `size` and `expiresUnix`.
web_src/js/features/repo-actions.ts	Wires new locale string (`artifactExpiresAt`) into the Vue view props.
web_src/js/components/RepoActionView.vue	Attaches artifact hover tooltips and adjusts artifact list styling.
web_src/js/components/ActionRunArtifacts.ts	Implements tooltip element creation (expiry + size).
web_src/js/components/ActionRunArtifacts.test.ts	Adds unit tests for tooltip element creation.
templates/repo/actions/view_component.tmpl	Adds `data-locale-artifact-expires-at` for the run view.
templates/devtest/relative-time.tmpl	Adds a devtest example including minute-level formatting.
routers/web/repo/actions/view.go	Adds `expiresUnix` to artifacts JSON returned by the run view endpoint.
routers/web/devtest/mock_actions.go	Populates mock artifacts with `ExpiresUnix` values for devtest.
options/locale/locale_en-US.json	Adds `artifact_expires_at` locale string.
models/actions/artifact.go	Includes `expired_unix` in grouped artifact meta query results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

web_src/js/components/RepoActionView.vue

web_src/js/components/ActionRunArtifacts.ts

- encodeURIComponent on artifact download href for names with spaces or special characters - Use minute='2-digit' on relative-time for consistent zero-padding Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

- Replace text pipe with border-left separator via Tailwind classes - Remove flexbox on tooltip container to preserve whitespace between locale text and relative-time element - Fix empty line at end of style block Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-09T20:54:35Z

Latest screenshot:

bircni · 2026-04-09T21:25:28Z

thanks for your help @silverwind

…sion Replace loop-based byte formatting with log-based approach. The function now accepts suffix and precision options, defaulting to byte formatting with IEC binary units (KiB, MiB, GiB). Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Replace loop-based division with log2-based exponent calculation. Add precision parameter for configurable significant digits. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind · 2026-04-09T21:56:28Z

some minor refactors done to formatBytes, now log-based, output is same as before.

wxiaoguang · 2026-04-09T23:32:07Z

web_src/js/components/RepoActionView.vue

+function initSidebarTooltip(el: HTMLElement | null, content: string | HTMLElement) {
+  if (!el) return;
+  if (el._tippy) {
+    el._tippy.setContent(content);
+  } else {
+    createTippy(el, {content, role: 'tooltip', theme: 'tooltip', placement: 'top-end', arrow: false, offset: [0, 2]});
+  }
+}


You need to improve the framework, instead of making future developers copy&paste such code.

For example: data-tooltip-render-html="true"

I guess some generic way to specify all tippy props in HTML is needed. Should be done with a future migration to https://github.com/floating-ui/floating-ui in mind.

I guess some generic way to specify all tippy props in HTML is needed.

No, don't do more than it needs.

"tooltip" is "tooltip". Other tippy popups don't use "tooltip-content" for content.

silverwind · 2026-04-09T23:43:57Z

I see a few more refactor opportunities, will do later.

wxiaoguang · 2026-04-10T04:47:14Z

web_src/js/components/RepoActionView.vue

+.action-view-left .ui.relaxed.list > .item {
+  padding-top: 0;
+  padding-bottom: 0;
+}
+
+.action-view-left .ui.relaxed.list > .item > :first-child {
+  padding-top: 0.42857143em;
+  padding-bottom: 0.42857143em;
+}
+


By the way, don't use such trick. You can see it breaks the UI , makes the "job list" very narrow.

This is a minor fix to have the full vertical area hoverable (e.g. link turns blue on .item mouseenter), but I think it needs a cleaner solution. In my testing, visually there was no difference, padding just moved from .item to .item > a.

Will check. Likely refactor to a.item.

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2026

github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Apr 3, 2026

bircni changed the title ~~restart~~ Workflow Artifact Info Hover Apr 3, 2026

bircni force-pushed the feature/add-artifact-expiry-hover branch from aee7bce to 9c7e067 Compare April 3, 2026 21:51

Add artifact expiry feature with tooltip and localization support

5d9a44e

bircni force-pushed the feature/add-artifact-expiry-hover branch from 9c7e067 to 5d9a44e Compare April 3, 2026 21:53

silverwind reviewed Apr 3, 2026

View reviewed changes

options/locale/locale_en-US.json Outdated Show resolved Hide resolved

fixes

7759b8d

Merge branch 'main' into feature/add-artifact-expiry-hover

96d62cf

bircni requested a review from silverwind April 6, 2026 10:26

silverwind and others added 2 commits April 9, 2026 21:01

Merge branch 'main' into feature/add-artifact-expiry-hover

415044d

Improve artifact link click area and tooltip spacing

06ba537

Move vertical padding from li to first-child so the link covers the full row height. Reduce tooltip offset to 2px. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind requested a review from Copilot April 9, 2026 20:19

silverwind added the backport/v1.26 This PR should be backported to Gitea 1.26 label Apr 9, 2026

Copilot started reviewing on behalf of silverwind April 9, 2026 20:22 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

silverwind and others added 3 commits April 9, 2026 22:31

Encode artifact name in download URL, use 2-digit minutes

83f0d17

- encodeURIComponent on artifact download href for names with spaces or special characters - Use minute='2-digit' on relative-time for consistent zero-padding Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

Update devtest relative-time to use minute=2-digit

322023f

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind force-pushed the feature/add-artifact-expiry-hover branch from b6c8792 to 3887aaf Compare April 9, 2026 20:44

Simplify formatBytes

840ca21

Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

silverwind marked this pull request as ready for review April 9, 2026 20:45

Merge branch 'main' into feature/add-artifact-expiry-hover

6cc7c34

silverwind approved these changes Apr 9, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2026

bircni requested a review from wxiaoguang April 9, 2026 21:25

silverwind and others added 2 commits April 9, 2026 23:49

Refactor formatBytes to use log-based unit calculation

f822379

Replace loop-based division with log2-based exponent calculation. Add precision parameter for configurable significant digits. Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>

wxiaoguang reviewed Apr 9, 2026

View reviewed changes

silverwind self-requested a review April 9, 2026 23:43

GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 9, 2026

wxiaoguang removed the backport/v1.26 This PR should be backported to Gitea 1.26 label Apr 10, 2026

wxiaoguang marked this pull request as draft April 10, 2026 04:44

wxiaoguang reviewed Apr 10, 2026

View reviewed changes

Uh oh!

Conversation

bircni commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 3, 2026

Uh oh!

Uh oh!

bircni commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Apr 9, 2026

Uh oh!

silverwind commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Apr 9, 2026

Uh oh!

bircni commented Apr 9, 2026

Uh oh!

silverwind commented Apr 9, 2026

Uh oh!

wxiaoguang Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

silverwind Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

silverwind commented Apr 9, 2026

Uh oh!

wxiaoguang Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

silverwind Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bircni commented Apr 3, 2026 •

edited

Loading

bircni commented Apr 4, 2026 •

edited

Loading

silverwind commented Apr 4, 2026 •

edited

Loading

silverwind commented Apr 9, 2026 •

edited

Loading

silverwind Apr 9, 2026 •

edited

Loading

silverwind Apr 10, 2026 •

edited

Loading